linux-kernel - Re: [PATCH] perf pmu: Fix a potential memory leak in perf_pmu_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e1ed5a3-55dc-4652-936d-fd36e0442d79@wanadoo.fr>
Date: Sun, 25 Feb 2024 16:42:15 +0100
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
 Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Arnaldo Carvalho de Melo <acme@...hat.com>, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf pmu: Fix a potential memory leak in
 perf_pmu__lookup()

Le 26/08/2023 à 23:32, Christophe JAILLET a écrit :
> The commit in Fixes has reordered some code, but missed an error handling
> path.
> 
> 'goto err' now, in order to avoid a memory leak in case of error.
> 
> Fixes: f63a536f03a2 ("perf pmu: Merge JSON events with sysfs at load time")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---

Hi,

polite reminder.

CJ


>   tools/perf/util/pmu.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index bb2ca29cd7bd..8dfce84ad9fe 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -1018,10 +1018,9 @@ struct perf_pmu *perf_pmu__lookup(struct list_head *pmus, int dirfd, const char
>   	 * type value and format definitions. Load both right
>   	 * now.
>   	 */
> -	if (pmu_format(pmu, dirfd, name)) {
> -		free(pmu);
> -		return NULL;
> -	}
> +	if (pmu_format(pmu, dirfd, name))
> +		goto err;
> +
>   	pmu->is_core = is_pmu_core(name);
>   	pmu->cpus = pmu_cpumask(dirfd, name, pmu->is_core);
>