linux-kernel - Re: [PATCH] dt-bindings: serial: convert st,asc to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <174b85c4-107b-44ea-af81-4564101aa5ec@linaro.org>
Date: Sun, 25 Feb 2024 16:42:31 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Raphael Gallais-Pou <rgallaispou@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Patrice Chotard <patrice.chotard@...s.st.com>
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: serial: convert st,asc to DT schema

On 25/02/2024 11:03, Raphael Gallais-Pou wrote:
> Converts st,asc binding to DT schema format and update example.
> 
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@...il.com>
> ---
>  .../devicetree/bindings/serial/st,asc.yaml    | 57 +++++++++++++++++++
>  .../devicetree/bindings/serial/st-asc.txt     | 18 ------
>  2 files changed, 57 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/serial/st,asc.yaml
>  delete mode 100644 Documentation/devicetree/bindings/serial/st-asc.txt
> 
> diff --git a/Documentation/devicetree/bindings/serial/st,asc.yaml b/Documentation/devicetree/bindings/serial/st,asc.yaml
> new file mode 100644
> index 000000000000..b26e1d247346
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/st,asc.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serial/st,asc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STi SoCs Serial Port
> +
> +maintainers:
> +  - Patrice Chotard <patrice.chotard@...s.st.com>
> +
> +allOf:
> +  - $ref: serial.yaml#
> +
> +properties:
> +  compatible:
> +    const: st,asc
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1

This wasn't here before and your commit msg does not explain it.

> +
> +  uart-has-rtscts: true

Drop, not needed.

> +
> +  st,hw-flow-ctrl:
> +    description: When set, enable hardware flow control.
> +    type: boolean
> +
> +  st,force-m1:
> +    description: When set, force asc to be in Mode-1. This is recommended for
> +      high bit rates above 19.2K.
> +    type: boolean
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks

Also something new.




Best regards,
Krzysztof