[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZdyQdGkSIw9OsSqc@casper.infradead.org>
Date: Mon, 26 Feb 2024 13:21:56 +0000
From: Matthew Wilcox <willy@...radead.org>
To: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
Cc: linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org, david@...morbit.com,
chandan.babu@...cle.com, akpm@...ux-foundation.org,
mcgrof@...nel.org, ziy@...dia.com, hare@...e.de, djwong@...nel.org,
gost.dev@...sung.com, linux-mm@...ck.org,
Pankaj Raghav <p.raghav@...sung.com>
Subject: Re: [PATCH 12/13] xfs: make the calculation generic in
xfs_sb_validate_fsb_count()
On Mon, Feb 26, 2024 at 10:49:35AM +0100, Pankaj Raghav (Samsung) wrote:
> + if (check_mul_overflow(nblocks, (1 << sbp->sb_blocklog), &bytes))
Why would you not use check_shl_overflow()?
> + return -EFBIG;
> +
> + mapping_count = bytes >> PAGE_SHIFT;
> /* Limited by ULONG_MAX of page cache index */
> - if (nblocks >> (PAGE_SHIFT - sbp->sb_blocklog) > ULONG_MAX)
> + if (mapping_count > ULONG_MAX)
> return -EFBIG;
> return 0;
> }
> --
> 2.43.0
>
Powered by blists - more mailing lists