[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZdyRhpViddO9TKDs@casper.infradead.org>
Date: Mon, 26 Feb 2024 13:26:30 +0000
From: Matthew Wilcox <willy@...radead.org>
To: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
Cc: linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org, david@...morbit.com,
chandan.babu@...cle.com, akpm@...ux-foundation.org,
mcgrof@...nel.org, ziy@...dia.com, hare@...e.de, djwong@...nel.org,
gost.dev@...sung.com, linux-mm@...ck.org,
Pankaj Raghav <p.raghav@...sung.com>
Subject: Re: [PATCH 13/13] xfs: enable block size larger than page size
support
On Mon, Feb 26, 2024 at 10:49:36AM +0100, Pankaj Raghav (Samsung) wrote:
> @@ -1625,16 +1625,10 @@ xfs_fs_fill_super(
> goto out_free_sb;
> }
>
> - /*
> - * Until this is fixed only page-sized or smaller data blocks work.
> - */
> if (mp->m_sb.sb_blocksize > PAGE_SIZE) {
> xfs_warn(mp,
> - "File system with blocksize %d bytes. "
> - "Only pagesize (%ld) or less will currently work.",
> - mp->m_sb.sb_blocksize, PAGE_SIZE);
> - error = -ENOSYS;
> - goto out_free_sb;
> +"EXPERIMENTAL: Filesystem with Large Block Size (%d bytes) enabled.",
> + mp->m_sb.sb_blocksize);
WARN seems a little high for this. xfs_notice() or xfs_info() would
seem more appropriate:
#define KERN_WARNING KERN_SOH "4" /* warning conditions */
#define KERN_NOTICE KERN_SOH "5" /* normal but significant condition */
#define KERN_INFO KERN_SOH "6" /* informational */
Powered by blists - more mailing lists