[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240226133326.yoa4vwbdob3kkczq@basti-XPS-13-9310>
Date: Mon, 26 Feb 2024 14:33:26 +0100
From: Sebastian Fricke <sebastian.fricke@...labora.com>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: Nas Chung <nas.chung@...psnmedia.com>,
Jackson Lee <jackson.lee@...psnmedia.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: wave5: Remove unnecessary semicolons
Hey Thorsten,
Thanks for the patch, change looks obviously good, one small thing to
note for the future, the commit title should start with:
media: chips-media: wave5:
instead of:
drivers: wave5:
I will change that myself this time, but please do a quick git log next
time to check how the path should be formatted for the driver.
Greetings,
Sebastian
On 13.02.2024 15:04, Thorsten Blum wrote:
>Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
>semantic patch at scripts/coccinelle/misc/semicolon.cocci.
>
>Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
>---
> drivers/media/platform/chips-media/wave5/wave5-hw.c | 2 +-
> drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
>index f1e022fb148e..2d82791f575e 100644
>--- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
>+++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
>@@ -2315,7 +2315,7 @@ static bool wave5_vpu_enc_check_common_param_valid(struct vpu_instance *inst,
> param->intra_refresh_mode);
> return false;
> }
>- };
>+ }
> return true;
>
> invalid_refresh_argument:
>diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
>index f29cfa3af94a..8bbf9d10b467 100644
>--- a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
>+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
>@@ -92,7 +92,7 @@ static int switch_state(struct vpu_instance *inst, enum vpu_instance_state state
> break;
> case VPU_INST_STATE_STOP:
> break;
>- };
>+ }
>
> dev_dbg(inst->dev->dev, "Switch state from %s to %s.\n",
> state_to_str(inst->state), state_to_str(state));
>--
>2.43.0
>
>
Powered by blists - more mailing lists