linux-kernel - Re: [PATCH] zonefs: remove SLAB_MEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cdbfed3-62cd-41fd-b71a-5c6b1940ceb6@kernel.org>
Date: Mon, 26 Feb 2024 05:33:14 -0800
From: Damien Le Moal <dlemoal@...nel.org>
To: chengming.zhou@...ux.dev, naohiro.aota@....com, jth@...nel.org
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, vbabka@...e.cz, roman.gushchin@...ux.dev,
 Xiongwei.Song@...driver.com, Chengming Zhou <zhouchengming@...edance.com>
Subject: Re: [PATCH] zonefs: remove SLAB_MEM_SPREAD flag usage

On 2024/02/24 5:53, chengming.zhou@...ux.dev wrote:
> From: Chengming Zhou <zhouchengming@...edance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>
> ---
>  fs/zonefs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index 236a6d88306f..c6a124e8d565 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -1422,7 +1422,7 @@ static int __init zonefs_init_inodecache(void)
>  {
>  	zonefs_inode_cachep = kmem_cache_create("zonefs_inode_cache",
>  			sizeof(struct zonefs_inode_info), 0,
> -			(SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD | SLAB_ACCOUNT),
> +			SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT,
>  			NULL);
>  	if (zonefs_inode_cachep == NULL)
>  		return -ENOMEM;

Looks good, but please rework the commit message as you suggested on the btrfs
list to have more details about this change. Thanks.

-- 
Damien Le Moal
Western Digital Research