linux-kernel - Re: [PATCH] zonefs: remove SLAB_MEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <955791a3-5fa2-4473-b69d-a9a56ee6f98d@linux.dev>
Date: Mon, 26 Feb 2024 21:44:47 +0800
From: Chengming Zhou <chengming.zhou@...ux.dev>
To: Damien Le Moal <dlemoal@...nel.org>, naohiro.aota@....com, jth@...nel.org
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, vbabka@...e.cz, roman.gushchin@...ux.dev,
 Xiongwei.Song@...driver.com
Subject: Re: [PATCH] zonefs: remove SLAB_MEM_SPREAD flag usage

On 2024/2/26 21:33, Damien Le Moal wrote:
> On 2024/02/24 5:53, chengming.zhou@...ux.dev wrote:
>> From: Chengming Zhou <zhouchengming@...edance.com>
>>
>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>> its usage so we can delete it from slab. No functional change.
>>
>> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>
>> ---
>>  fs/zonefs/super.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
>> index 236a6d88306f..c6a124e8d565 100644
>> --- a/fs/zonefs/super.c
>> +++ b/fs/zonefs/super.c
>> @@ -1422,7 +1422,7 @@ static int __init zonefs_init_inodecache(void)
>>  {
>>  	zonefs_inode_cachep = kmem_cache_create("zonefs_inode_cache",
>>  			sizeof(struct zonefs_inode_info), 0,
>> -			(SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD | SLAB_ACCOUNT),
>> +			SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT,
>>  			NULL);
>>  	if (zonefs_inode_cachep == NULL)
>>  		return -ENOMEM;
> 
> Looks good, but please rework the commit message as you suggested on the btrfs
> list to have more details about this change. Thanks.
> 

Ok, Christoph Hellwig suggested me to send these patches as a single patch after
6.9-rc1 release, only need slab maintainers ACK. So I stopped bothering you. :)

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete to avoid confusion for users.
Here we can just remove all its users, which has no functional change.

[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/

Thanks!