linux-kernel - Re: [tip: x86/apic] smp: Provide 'setup_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240226150234.GCZdyoCtNj8lFwViAW@fat_crate.local>
Date: Mon, 26 Feb 2024 16:02:34 +0100
From: Borislav Petkov <bp@...en8.de>
To: linux-kernel@...r.kernel.org
Cc: linux-tip-commits@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>, x86@...nel.org
Subject: Re: [tip: x86/apic] smp: Provide 'setup_max_cpus' definition on UP
 too

On Mon, Feb 26, 2024 at 11:48:06AM -0000, tip-bot2 for Ingo Molnar wrote:
> The following commit has been merged into the x86/apic branch of tip:
> 
> Commit-ID:     429bb0269058e2e1f4ab69a0d33d374933aa15b9
> Gitweb:        https://git.kernel.org/tip/429bb0269058e2e1f4ab69a0d33d374933aa15b9
> Author:        Ingo Molnar <mingo@...nel.org>
> AuthorDate:    Mon, 26 Feb 2024 12:07:31 +01:00
> Committer:     Ingo Molnar <mingo@...nel.org>
> CommitterDate: Mon, 26 Feb 2024 12:13:40 +01:00
> 
> smp: Provide 'setup_max_cpus' definition on UP too
> 
> This was already defined locally by init/main.c, but let's make
> it generic, as arch/x86/kernel/cpu/topology.c is going to make
> use of it to have more uniform code.
> 
> [ Keep it a C variable, not a define, because there's
>   some namespace overlap for the 'setup_max_cpus' token
>   in existing function argument names. ]
> 
> Reviewed-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> --
> ---
>  include/linux/smp.h | 2 ++
>  init/main.c         | 1 -
>  2 files changed, 2 insertions(+), 1 deletion(-)

That one needs some work:

$ grep setup_max_cpus 13-37-17-randconfig-x86_64-2517.log
..
/include/linux/smp.h:221:27: warning: ‘setup_max_cpus’ defined but not used [-Wunused-const-variable=]
$ grep setup_max_cpus 13-37-17-randconfig-x86_64-2517.log  | wc -l
122

very noisy.

randconfig attached.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

View attachment "13-37-17-randconfig-x86_64-2517.cfg" of type "text/plain" (200992 bytes)