[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1j4jdvdr5l.fsf@starbuckisacylon.baylibre.com>
Date: Mon, 26 Feb 2024 19:15:41 +0100
From: Jerome Brunet <jbrunet@...libre.com>
To: Mark Brown <broonie@...nel.org>
Cc: Jerome Brunet <jbrunet@...libre.com>, Liam Girdwood
<lgirdwood@...il.com>, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH 6/6] ASoC: meson: axg-fifo: use FIELD helpers
On Mon 26 Feb 2024 at 15:42, Mark Brown <broonie@...nel.org> wrote:
> [[PGP Signed Part:Undecided]]
> On Fri, Feb 23, 2024 at 06:51:12PM +0100, Jerome Brunet wrote:
>
>> Use FIELD_GET() and FIELD_PREP() helpers instead of doing it manually.
>
> This breaks the build for me:
>
> /build/stage/linux/sound/soc/meson/axg-fifo.c: In function ‘axg_fifo_pcm_hw_para
> ms’:
> /build/stage/linux/sound/soc/meson/axg-fifo.c:149:28: error: implicit declaratio
> n of function ‘FIELD_PREP’ [-Werror=implicit-function-declaration]
> 149 | FIELD_PREP(CTRL0_INT_EN, irq_en));
> | ^~~~~~~~~~
> /build/stage/linux/sound/soc/meson/axg-fifo.c: In function ‘axg_fifo_pcm_irq_blo
> ck’:
> /build/stage/linux/sound/soc/meson/axg-fifo.c:207:18: error: implicit declaratio
> n of function ‘FIELD_GET’ [-Werror=implicit-function-declaration]
> 207 | status = FIELD_GET(STATUS1_INT_STS, status);
> | ^~~~~~~~~
> cc1: all warnings being treated as errors
Ah, I forgot to include <linux/bitfield.h>. Thanks for letting me know.
I'll fix it
It was fine when I tested with ARCH=arm64 and the default defconfig so
most likely it got indirectly included.
Could you tell me which ARCH/defconfig triggered this ?
>
> [[End of PGP Signed Part]]
--
Jerome
Powered by blists - more mailing lists