linux-kernel - Re: [PATCH net-next v6 5/8] net: phy: Immediately call adjust_link if only tx_lpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe071598-64eb-4dd2-8926-d4d0954e7e7e@lunn.ch>
Date: Mon, 26 Feb 2024 19:59:28 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Wei Fang <wei.fang@....com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Heiner Kallweit <hkallweit1@...il.com>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Shenwei Wang <shenwei.wang@....com>,
	Clark Wang <xiaoning.wang@....com>,
	NXP Linux Team <linux-imx@....com>
Subject: Re: [PATCH net-next v6 5/8] net: phy: Immediately call adjust_link
 if only tx_lpi_enabled changes

On Mon, Feb 26, 2024 at 05:53:31PM +0000, Russell King (Oracle) wrote:
> On Mon, Feb 26, 2024 at 09:50:02AM -0800, Florian Fainelli wrote:
> > This is the source of the concern, we don't know which MAC drivers we might
> > end-up breaking by calling adjust_link(link == 1) twice in a row, hopefully
> > none, because they should be well written to only update the parameters that
> > need updating, but who knows?
> 
> Just quickly... There are some (I went through a bunch.) They don't
> support EEE. I haven't been through all though, so there could be
> some which support EEE and where adjust_link() with phydev->link=true
> twice in a row could result in badness.

So i think we all agree the MAC needs to see a down/up, even if the
link itself never went down. Anything else is too risky and will
probably break something somewhere.

	 Andrew