linux-kernel - [PATCH] iommu/amd: drop unused but set variable entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Mon, 26 Feb 2024 09:56:30 +0800
From: Kunwu Chan <kunwu.chan@...mail.com>
To: joro@...tes.org,
	suravee.suthikulpanit@....com,
	will@...nel.org,
	robin.murphy@....com
Cc: iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Kunwu Chan <kunwu.chan@...mail.com>
Subject: [PATCH] iommu/amd: drop unused but set variable entry

Fix compile warning:
drivers/iommu/amd/iommu.c: In function 'iommu_poll_ppr_log':
drivers/iommu/amd/iommu.c:833:21: Warning:
Variable 'entry' is set but not used [-Wunused-but-set-variable]

Commit d55b0d2e075a("iommu/amd: Remove PPR support")
removes the use of 'entry', but does not delete this variable.

Signed-off-by: Kunwu Chan <kunwu.chan@...mail.com>
---
 drivers/iommu/amd/iommu.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index 4283dd8191f0..de771a6420dc 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -831,7 +831,6 @@ static void iommu_poll_ppr_log(struct amd_iommu *iommu)
 
 	while (head != tail) {
 		volatile u64 *raw;
-		u64 entry[2];
 		int i;
 
 		raw = (u64 *)(iommu->ppr_log + head);
@@ -847,10 +846,6 @@ static void iommu_poll_ppr_log(struct amd_iommu *iommu)
 			udelay(1);
 		}
 
-		/* Avoid memcpy function-call overhead */
-		entry[0] = raw[0];
-		entry[1] = raw[1];
-
 		/*
 		 * To detect the hardware errata 733 we need to clear the
 		 * entry back to zero. This issue does not exist on SNP
-- 
2.39.2