linux-kernel - Re: [PATCH] vdso/datapage: Quick fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87cyshapkd.ffs@tglx>
Date: Tue, 27 Feb 2024 16:34:42 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Catalin Marinas <catalin.marinas@....com>, Anna-Maria Behnsen
 <anna-maria@...utronix.de>
Cc: linux-kernel@...r.kernel.org, Andy Lutomirski <luto@...nel.org>,
 Vincenzo Frascino <vincenzo.frascino@....com>, Arnd Bergmann
 <arnd@...nel.org>, Kees Cook <keescook@...omium.org>, Will Deacon
 <will@...nel.org>, linux-arm-kernel@...ts.infradead.org, Linux Kernel
 Functional Testing <lkft@...aro.org>
Subject: Re: [PATCH] vdso/datapage: Quick fix - use asm/page-def.h for ARM64

On Tue, Feb 27 2024 at 13:44, Catalin Marinas wrote:
> On Mon, Feb 26, 2024 at 06:50:23PM +0100, Anna-Maria Behnsen wrote:
>> diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h
>> index 7ba44379a095..5d5c0b8efff2 100644
>> --- a/include/vdso/datapage.h
>> +++ b/include/vdso/datapage.h
>> @@ -19,7 +19,11 @@
>>  #include <vdso/time32.h>
>>  #include <vdso/time64.h>
>>  
>> +#ifdef CONFIG_ARM64
>> +#include <asm/page-def.h>
>> +#else
>>  #include <asm/page.h>
>> +#endif
>
> I'm not a fan of guarding includes but I guess this would do until we
> merge Arnd's clean-up patches. FWIW:

Nobody is a fan of that, but the cleanup is not available tomorrow :)