linux-kernel - Re: [PATCH RESEND 1/2] prctl: Generalize PR_SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 27 Feb 2024 20:53:59 +0100
From: Helge Deller <deller@....de>
To: "Russell King (Oracle)" <linux@...linux.org.uk>,
 Zev Weiss <zev@...ilderbeest.net>
Cc: linux-parisc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Florent Revest <revest@...omium.org>,
 "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
 "Borislav Petkov (AMD)" <bp@...en8.de>, Yin Fengwei <fengwei.yin@...el.com>,
 "Mike Rapoport (IBM)" <rppt@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>, Kees Cook
 <keescook@...omium.org>, Yang Shi <yang@...amperecomputing.com>,
 Rick Edgecombe <rick.p.edgecombe@...el.com>, Oleg Nesterov
 <oleg@...hat.com>, David Hildenbrand <david@...hat.com>,
 Stefan Roesch <shr@...kernel.io>, Josh Triplett <josh@...htriplett.org>,
 Ondrej Mosnacek <omosnace@...hat.com>, Miguel Ojeda <ojeda@...nel.org>,
 linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org,
 Sam James <sam@...too.org>, stable@...r.kernel.org
Subject: Re: [PATCH RESEND 1/2] prctl: Generalize PR_SET_MDWE support check to
 be per-arch

On 2/27/24 11:24, Russell King (Oracle) wrote:
> On Mon, Feb 26, 2024 at 05:35:41PM -0800, Zev Weiss wrote:
>> There exist systems other than PARISC where MDWE may not be feasible
>> to support; rather than cluttering up the generic code with additional
>> arch-specific logic let's add a generic function for checking MDWE
>> support and allow each arch to override it as needed.
>>
>> Signed-off-by: Zev Weiss <zev@...ilderbeest.net>
>> Cc: <stable@...r.kernel.org> # v6.3+
>
> PA-RISC folk need to ack/review-by this patch.

I'm fine with patch 1/2:
Acked-by: Helge Deller <deller@....de> # parisc

> Alternatively, it needs
> to be restructured to add the arch_memory_deny_write_exec_supported()
> override without touching the PA-RISC code, which then makes the Arm
> patch independent of the status of the PA-RISC patch. That will allow
> the Arm issue to be solved even if an ack is not forthcoming for the
> PA-RISC parts.
>> Alternatively, I wonder whether akpm would be willing to pick up this
> patch set as-is.

I have no preference, but I think both patches should be pushed
together via arm tree or akpm.

Helge