linux-kernel - Re: [PATCH] dt-bindings: iio: gyroscope: bosch,bmg160: add spi-max-frequency binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240227215157.3uuohzijesy6zcu5@pengutronix.de>
Date: Tue, 27 Feb 2024 22:51:57 +0100
From: Marco Felsch <m.felsch@...gutronix.de>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, lars@...afoo.de,
	robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, hns@...delico.com, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH] dt-bindings: iio: gyroscope: bosch,bmg160: add
 spi-max-frequency binding

On 24-02-27, Jonathan Cameron wrote:
> On Mon, 26 Feb 2024 14:18:00 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> 
> > On 26/02/2024 13:40, Marco Felsch wrote:
> > > On 24-02-26, Krzysztof Kozlowski wrote:  
> > >> On 21/02/2024 18:43, Marco Felsch wrote:  
> > >>> Make use of the common spi-peripheral-props.yaml to pull in the common
> > >>> spi device properties and limit the spi-max-frequency to 10 MHz as this
> > >>> is the max. frequency if VDDIO >= 1.62V.  
> > >>
> > >> The example uses i2c, so I would expect to see in commit msg explanation
> > >> which devices are SPI devices.  
> > > 
> > > All listed devices can either operate in I2C or in SPI mode.  
> > 
> > Such information in commit msg would be enough.
> > 
> > with the changes:
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > 
> > Best regards,
> > Krzysztof
> > 
> 
> Added the note whilst applying.

Thanks a lot :)

Regards,
  Marco

> Applied to the togreg branch of iio.git and pushed out (briefly given
> timing) as testing for 0-day to take a first look.
> 
> Thanks,
> 
> Jonathan
>