linux-kernel - Re: [PATCH v2] mm: make folio_pte_batch available outside of mm/memory.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240227215426.153162-1-sj@kernel.org>
Date: Tue, 27 Feb 2024 13:54:26 -0800
From: SeongJae Park <sj@...nel.org>
To: Barry Song <21cnbao@...il.com>
Cc: akpm@...ux-foundation.org,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Barry Song <v-songbaohua@...o.com>,
	David Hildenbrand <david@...hat.com>,
	Lance Yang <ioworker0@...il.com>,
	Ryan Roberts <ryan.roberts@....com>,
	Yin Fengwei <fengwei.yin@...el.com>
Subject: Re: [PATCH v2] mm: make folio_pte_batch available outside of mm/memory.c

On Tue, 27 Feb 2024 23:42:01 +1300 Barry Song <21cnbao@...il.com> wrote:

> From: Barry Song <v-songbaohua@...o.com>
> 
> madvise, mprotect and some others might need folio_pte_batch to check if
> a range of PTEs are completely mapped to a large folio with contiguous
> physical addresses. Let's make it available in mm/internal.h.

Hi Barry,


I found this patch makes some of my build test that not setting CONFIG_MMU
fails with multiple errors including below:

    In file included from .../mm/nommu.c:43:
    .../mm/internal.h: In function '__pte_batch_clear_ignored':
    .../mm/internal.h:98:23: error: implicit declaration of function 'pte_mkclean'; did you mean 'page_mkclean'? [-Werror=implicit-function-declaration]
       98 |                 pte = pte_mkclean(pte);
          |                       ^~~~~~~~~~~
          |                       page_mkclean

Enabling CONFIG_MMU made the build success.  I haven't had a time to look into
the code yet.  May I ask your opinion?


Thanks,
SJ

[...]