linux-kernel - Re: [PATCH] dt-bindings: soc: renesas: renesas-soc: Add pattern for gray-hawk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 27 Feb 2024 23:36:08 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Niklas Söderlund <niklas.soderlund@...natech.se>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH] dt-bindings: soc: renesas: renesas-soc: Add pattern for gray-hawk

Hi Niklas,

Thank you for the review.

On Tue, Feb 27, 2024 at 11:33 PM Niklas Söderlund
<niklas.soderlund@...natech.se> wrote:
>
> Hi Prabhakar,
>
> Thanks for your work.
>
> On 2024-02-27 22:09:30 +0000, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Add pattern for Renesas Gray Hawk Single board (based on R-Car V4M SoC)
> > to fix the below dtbs_check issue:
> >
> > arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dtb: /: compatible:0: 'anyOf' conditional failed, one must be fixed:
> > 4695 'renesas,gray-hawk-single' does not match '^renesas,(emev2|r(7s|8a|9a)[a-z0-9]+|rcar|rmobile|rz[a-z0-9]*|sh(7[a-z0-9]+)?|mobile)-[a-z0-9-]+$'
> > 4696 'renesas,gray-hawk-single' does not match '^renesas,(condor|falcon|gr-peach|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$'
> > 4697 'renesas,gray-hawk-single' does not match '^renesas,(can|cpg|dmac|du|(g)?ether(avb)?|gpio|hscif|(r)?i[i2]c|imr|intc|ipmmu|irqc|jpu|mmcif|msiof|mtu2|pci(e)?|pfc|pwm|[rq]spi|rcar_sound|sata|scif[ab]*|sdhi|thermal|tmu|tpu|usb(2|hs)?|vin|xhci)-[a-z0-9-]+$'
> > 4698 'renesas,gray-hawk-single' does not match '^renesas,(d|s)?bsc(3)?-(r8a73a4|r8a7740|sh73a0)$'
> > 4699 'renesas,gray-hawk-single' does not match '^renesas,em-(gio|sti|uart)$'
> > 4700 'renesas,gray-hawk-single' does not match '^renesas,fsi2-(r8a7740|sh73a0)$'
> > 4701 'renesas,gray-hawk-single' does not match '^renesas,hspi-r8a777[89]$'
> > 4702 'renesas,gray-hawk-single' does not match '^renesas,sysc-(r8a73a4|r8a7740|rmobile|sh73a0)$'
> > 4703 'renesas,gray-hawk-single' is not one of ['renesas,imr-lx4', 'renesas,mtu2-r7s72100']
> > 4704 'renesas,gray-hawk-single' is not one of ['renesas,smp-sram']
> > 4705 'renesas,gray-hawk-single' does not match '^(?!renesas,.+-.+).+$'
> > 4706 from schema $id: http://devicetree.org/schemas/soc/renesas/renesas-soc.yaml#
>
> The change is correct, but I don't think you need to phrase the commit
> message as fixing an error. This change extends renesas-soc.yaml with
> support for gray-hawk.
>
Aha I see, I wasn't aware gray-hawk was added after renesas-soc.yaml
was introduced. I'll reword the commit description and send a v2.

Cheers,
Prabhakar

> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > ---
> >  Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
> > index a5fcd471983d..5ddd31f30f26 100644
> > --- a/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
> > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
> > @@ -37,7 +37,7 @@ properties:
> >        anyOf:
> >          # Preferred naming style for compatibles of SoC components
> >          - pattern: "^renesas,(emev2|r(7s|8a|9a)[a-z0-9]+|rcar|rmobile|rz[a-z0-9]*|sh(7[a-z0-9]+)?|mobile)-[a-z0-9-]+$"
> > -        - pattern: "^renesas,(condor|falcon|gr-peach|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$"
> > +        - pattern: "^renesas,(condor|falcon|gr-peach|gray-hawk|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$"
> >
> >          # Legacy compatibles
> >          #
> > --
> > 2.34.1
> >
>
> --
> Kind Regards,
> Niklas Söderlund