linux-kernel - Re: [PATCH] loongarch/crypto: Clean up useless assignment operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a7d0a9e-c56e-4ee2-a83b-00164a450abe@xen0n.name>
Date: Tue, 27 Feb 2024 15:42:49 +0800
From: WANG Xuerui <kernel@...0n.name>
To: 关文涛 <guanwentao@...ontech.com>,
 王昱力 <wangyuli@...ontech.com>,
 herbert <herbert@...dor.apana.org.au>, davem <davem@...emloft.net>,
 chenhuacai <chenhuacai@...nel.org>
Cc: linux-crypto <linux-crypto@...r.kernel.org>,
 loongarch <loongarch@...ts.linux.dev>,
 linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] loongarch/crypto: Clean up useless assignment operations

On 2/26/24 16:25, 关文涛 wrote:
> Sure,but we not seem to have "crc.w.d.w" dword asm in loongarch 32bit mode,now the whole file can only run in 64bit mode?
> 
> Thanks.

Sorry. I have checked the manual and it turns out you & Yuli are 
correct: even though the narrower CRC instructions doesn't require 
GRLEN=64, they still *aren't* part of LA32 (LoongArch reference manual 
v1.10, Volume 1, Table 2-1). Counter-intuitive as it is, the original 
patch is correct nevertheless.

I'm going to amend my review shortly.

-- 
WANG "xen0n" Xuerui

Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/