linux-kernel - Re: [PATCH] loongarch/crypto: Clean up useless assignment operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 27 Feb 2024 17:22:18 +0800
From: Xi Ruoyao <xry111@...111.site>
To: WANG Xuerui <kernel@...0n.name>, 关文涛
	 <guanwentao@...ontech.com>, 王昱力
	 <wangyuli@...ontech.com>, herbert <herbert@...dor.apana.org.au>, davem
	 <davem@...emloft.net>, chenhuacai <chenhuacai@...nel.org>
Cc: linux-crypto <linux-crypto@...r.kernel.org>, loongarch
	 <loongarch@...ts.linux.dev>, linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] loongarch/crypto: Clean up useless assignment operations

On Tue, 2024-02-27 at 15:42 +0800, WANG Xuerui wrote:
> Sorry. I have checked the manual and it turns out you & Yuli are 
> correct: even though the narrower CRC instructions doesn't require 
> GRLEN=64, they still *aren't* part of LA32 (LoongArch reference manual
> v1.10, Volume 1, Table 2-1). Counter-intuitive as it is, the original 
> patch is correct nevertheless.

But I don't think the table in the spec will 100% reflect the real
status of the LA32 hardware.  And we should use CPUCFG to detect it
anyway.

Based on my experience programming some aeronautic device I'd say having
some hardware CRC support should be useful even in embedded area.

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University