lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAAhV-H4CXW5Lkn1=hMnMbcY3MO2eoos8bSr3Z5jY_piAbpP+5A@mail.gmail.com>
Date: Thu, 29 Feb 2024 11:05:22 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: WangYuli <wangyuli@...ontech.com>
Cc: herbert@...dor.apana.org.au, davem@...emloft.net, kernel@...0n.name, 
	linux-crypto@...r.kernel.org, loongarch@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, Guan Wentao <guanwentao@...ontech.com>
Subject: Re: [PATCH] loongarch/crypto: Clean up useless assignment operations

Hi, Yuli,

The code is fine to me, please change loongarch to LoongArch in the
subject, and update your commit message with Xuerui's review in V2.

Huacai

On Mon, Feb 26, 2024 at 4:04 PM WangYuli <wangyuli@...ontech.com> wrote:
>
> Both crc32 and crc32c hw accelerated funcs will calculate the
> remaining len. Those codes are derived from
> arch/mips/crypto/crc32-mips.c and "len -= sizeof(u32)" is not
> necessary for 64-bit CPUs.
>
> Removing it can make context code style more unified and improve
> code readability.
>
> Suggested-by: Guan Wentao <guanwentao@...ontech.com>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> ---
>  arch/loongarch/crypto/crc32-loongarch.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/loongarch/crypto/crc32-loongarch.c b/arch/loongarch/crypto/crc32-loongarch.c
> index a49e507af38c..3eebea3a7b47 100644
> --- a/arch/loongarch/crypto/crc32-loongarch.c
> +++ b/arch/loongarch/crypto/crc32-loongarch.c
> @@ -44,7 +44,6 @@ static u32 crc32_loongarch_hw(u32 crc_, const u8 *p, unsigned int len)
>
>                 CRC32(crc, value, w);
>                 p += sizeof(u32);
> -               len -= sizeof(u32);
>         }
>
>         if (len & sizeof(u16)) {
> @@ -80,7 +79,6 @@ static u32 crc32c_loongarch_hw(u32 crc_, const u8 *p, unsigned int len)
>
>                 CRC32C(crc, value, w);
>                 p += sizeof(u32);
> -               len -= sizeof(u32);
>         }
>
>         if (len & sizeof(u16)) {
> --
> 2.33.1
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ