linux-kernel - Re: [PATCH] media: mediatek: vcodec: avoid -Wcast-function-type-strict warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <54dcfb0c-9861-4abb-8a1f-83b5d1722ca8@app.fastmail.com>
Date: Tue, 27 Feb 2024 13:30:07 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Ricardo Ribalda Delgado" <ricardo.ribalda@...il.com>,
 "Arnd Bergmann" <arnd@...nel.org>
Cc: "Minghsiu Tsai" <minghsiu.tsai@...iatek.com>,
 "Houlong Wei" <houlong.wei@...iatek.com>,
 "Andrew-CT Chen" <andrew-ct.chen@...iatek.com>,
 "Mauro Carvalho Chehab" <mchehab@...nel.org>,
 "Matthias Brugger" <matthias.bgg@...il.com>,
 "AngeloGioacchino Del Regno" <angelogioacchino.delregno@...labora.com>,
 "Tiffany Lin" <tiffany.lin@...iatek.com>,
 "Yunfei Dong" <yunfei.dong@...iatek.com>,
 "Hans Verkuil" <hverkuil-cisco@...all.nl>,
 "Nicolas Dufresne" <nicolas.dufresne@...labora.com>,
 "Alexandre Courbot" <acourbot@...omium.org>,
 "Pi-Hsun Shih" <pihsun@...omium.org>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] media: mediatek: vcodec: avoid -Wcast-function-type-strict warning

On Tue, Feb 27, 2024, at 12:38, Ricardo Ribalda Delgado wrote:
> On Sat, Feb 24, 2024 at 1:11 PM Arnd Bergmann <arnd@...nel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> The ipi handler here tries hard to maintain const-ness of its argument,
>> but by doing that causes a warning about function type casts:
>
> I worked on the same issue, but in instead of removing the const, I
> tried to constify everything:
> https://patchwork.linuxtv.org/project/linux-media/patch/20240226-fix-clang-warnings-v2-3-fa1bc931d17e@chromium.org/

I had almost the same patch originally but ended up not sending
it because I could not figure out what to do about

typedef int (*rpmsg_rx_cb_t)(struct rpmsg_device *, void *, int, void *, u32);

which is a generic part of rpmsg that takes a non-const pointer
and gets called by mtk_rpmsg_ipi_handler(), which would now
get a const pointer.

     Arnd