linux-kernel - Re: [PATCH] platform/x86: thinkpad_acpi: Add more ThinkPads with non-standard reg address for fan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABxCQKtUFpiap-Zi5ihDD6W=NSd3Jn9RXykFPUz_Nj4WQ_qjWg@mail.gmail.com>
Date: Thu, 29 Feb 2024 06:43:05 +0900
From: Vishnu Sankar <vishnuocv@...il.com>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>
Cc: Hans de Goede <hdegoede@...hat.com>, Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>, linux-kernel@...r.kernel.org, 
	Vishnu Sankar <vsankar@...ovo.com>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Add more ThinkPads with
 non-standard reg address for fan

Hi Hans and Mark,

Thanks for the review.
On Thu, Feb 29, 2024 at 5:19 AM Mark Pearson <mpearson-lenovo@...ebb.ca> wrote:
>
> Hi Hans,
>
> On Wed, Feb 28, 2024, at 11:09 AM, Hans de Goede wrote:
> > Hi,
> >
> > On 2/28/24 16:01, Vishnu Sankar wrote:
> >> Add more ThinkPads with non-standard register addresses to read fan values.
> >>
> >> ThinkPads added are L13 Yoga Gen1, X13 Yoga Gen1, L380, L390, 11e Gen5 GL,
> >> 11e Gen5 GL-R, 11e Gen5 KL-Y.
> >>
> >> Signed-off-by: Vishnu Sankar <vishnuocv@...il.com>
> >
> > Thanks, I have no objection against this patch:
> >
> > Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> >
> > But this feels like it will become a game of whack-a-mole.
> >
> > Mark can you reach out to the ThinkPad firmware team and
> > figure out if there is some supported way to automatically detect
> > this ?
> >
> These are all older platforms and we're not expecting to see this on any newer platforms...if it shows up it's because they messed up (there is a spec and they're supposed to follow it).
> Vishnu did review with the FW team which platforms had used this implementation, and we believe the list below to be complete.
>
> Vishnu, please correct me if you've heard otherwise.
This is confirmed by the FW team.
The list of systems is complete and no more systems are expected (as of now).
>
> As a note, I did review this during an internal review, before Vishnu pushed it, so I'll add:
>
> Reviewed-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
>
> Mark



-- 

Regards,

      Vishnu Sankar
     +817015150407 (Japan)