linux-kernel - Re: [PATCH] fix linux kernel BTF builds: increase max percpu variables by 10x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <983b98db-79c0-4178-b88f-61f39d147cf7@nvidia.com>
Date: Wed, 28 Feb 2024 15:21:16 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Alan Maguire <alan.maguire@...cle.com>, Jiri Olsa <olsajiri@...il.com>
CC: Arnaldo Carvalho de Melo <acme@...hat.com>, Alexei Starovoitov
	<ast@...nel.org>, <bpf@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
	<dwarves@...r.kernel.org>
Subject: Re: [PATCH] fix linux kernel BTF builds: increase max percpu
 variables by 10x

On 2/28/24 04:04, Alan Maguire wrote:
> On 28/02/2024 09:20, Jiri Olsa wrote:
>> On Tue, Feb 27, 2024 at 07:21:42PM -0800, John Hubbard wrote:
..
>> do you have an actual count of percpu variables for your config?

That's a very reasonable question...

>> 10x seems a lot to me

Me too. This was a "make the problem go away now please" type of "fix". :)

>>
>> this might be a workaround, but we should make encoder->percpu.vars
>> dynamically allocated like we do for functions

Yes, that's a much better design imho.

>>
>> jirka
>>
> 
> Good idea Jiri; John would you mind trying the attached patch? Thanks!

It works perfectly for me. For that patch, please feel free to add:

Tested-by: John Hubbard <jhubbard@...dia.com>


thanks,
-- 
John Hubbard
NVIDIA