linux-kernel - Re: [PATCH v4 3/3] hwmon: Driver for Nuvoton NCT7363Y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 28 Feb 2024 01:03:58 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Paul Menzel <pmenzel@...gen.mpg.de>, Ban Feng <baneric926@...il.com>
Cc: jdelvare@...e.com, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 conor+dt@...nel.org, corbet@....net, linux-hwmon@...r.kernel.org,
 devicetree@...r.kernel.org, kcfeng0@...oton.com, kwliu@...oton.com,
 openbmc@...ts.ozlabs.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, DELPHINE_CHIU@...ynn.com,
 naresh.solanki@...ements.com, billy_tsai@...eedtech.com
Subject: Re: [PATCH v4 3/3] hwmon: Driver for Nuvoton NCT7363Y

On 2/27/24 23:57, Paul Menzel wrote:
> Dear Ban,
> 
> 
> Thank you for your patch. Some minor things from my side.
> 
> 
> Am 27.02.24 um 01:56 schrieb baneric926@...il.com:
>> From: Ban Feng <kcfeng0@...oton.com>
>>
>> NCT7363Y is an I2C based hardware monitoring chip from Nuvoton.
> 
> Please reference the datasheet.
> 

Note that something like

Datasheet: Available from Nuvoton upon request

is quite common for hardware monitoring chips and acceptable.

> Could you please give a high level description of the driver design?
> 

Can you be more specific ? I didn't have time yet to look into details,
but at first glance this looks like a standard hardware monitoring driver.
One could argue that the high level design of such drivers is described
in Documentation/hwmon/hwmon-kernel-api.rst.
I don't usually ask for a additional design information for hwmon drivers
unless some chip interaction is unusual and needs to be explained,
and then I prefer to have it explained in the code. Given that, I am
quite curious and would like to understand what you are looking for.

Thanks,
Guenter