linux-kernel - Re: [PATCH v2] wifi: brcm80211: handle pmk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 28 Feb 2024 13:54:43 +0100
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Duoming Zhou <duoming@....edu.cn>, linux-kernel@...r.kernel.org
Cc: brcm80211-dev-list.pdl@...adcom.com, brcm80211@...ts.linux.dev,
 linux-wireless@...r.kernel.org, justinstitt@...gle.com,
 jisoo.jang@...sei.ac.kr, petr.tesarik.ext@...wei.com,
 quic_alokad@...cinc.com, hdegoede@...hat.com, keescook@...omium.org,
 johannes.berg@...el.com, kvalo@...nel.org
Subject: Re: [PATCH v2] wifi: brcm80211: handle pmk_op allocation failure

On 2/28/2024 7:34 AM, Duoming Zhou wrote:
> The kzalloc() in brcmf_pmksa_v3_op() will return null if the
> physical memory has run out. As a result, if we dereference
> the null value, the null pointer dereference bug will happen.
> 
> Return -ENOMEM from brcmf_pmksa_v3_op() if kzalloc() fails
> for pmk_op.
> 
> Fixes: a96202acaea4 ("wifi: brcmfmac: cfg80211: Add support for PMKID_V3 operations")

Thanks!

Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Duoming Zhou <duoming@....edu.cn>
> ---
> Changes in v2:
>    - Drop the new label and just return -ENOMEM.
> 
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 +++
>   1 file changed, 3 insertions(+)

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)