linux-kernel - Re: [PATCH] firmware_loader: Use init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zd9OyMTgtYcFSEq3@bombadil.infradead.org>
Date: Wed, 28 Feb 2024 07:18:32 -0800
From: Luis Chamberlain <mcgrof@...nel.org>
To: John Garry <john.g.garry@...cle.com>
Cc: russ.weight@...ux.dev, gregkh@...uxfoundation.org, rafael@...nel.org,
	linux-kernel@...r.kernel.org, masahiroy@...nel.org
Subject: Re: [PATCH] firmware_loader: Use init_utsname()->release

On Wed, Feb 28, 2024 at 12:31:42PM +0000, John Garry wrote:
> On 27/02/2024 13:50, Luis Chamberlain wrote:
> > On Tue, Feb 27, 2024 at 01:02:26PM +0000, John Garry wrote:
> > > On 27/02/2024 12:59, Luis Chamberlain wrote:
> > > > What kernel are you seeing this issue on?
> > > I was testing v6.8-rc5 last week
> > I cannot reproduce a hung task there either on that kernel.
> > 
> > I see this:
> > 
> > sysfs: cannot create duplicate filename '/devices/virtual/misc/test_firmware/nope-test-firmware.bin'
> > 
> > But these are expected as the selftests tries silly things to ensure
> > they are not allowed.
> > 
> > If you can reproduce it there, it would be appreciated if you look underneath
> > the hood a bit, or share anything glaring and obvious which may help
> > reproduce this.
> 
> Update: commenting-out /lib/udev/rules.d/50-firmware.rules seems to make the
> test reliably pass for v6.8-rc5,

Great, note that if you had a hung task even with the udev rule that is
not expected and is indicative of a bug I cannot reproduce.

> but not with my patch on top - I still get
> a hang there. I'll investigate that hang with my patch.

So your hang is with the udev rule on vanilla v6.8-rc5 ? Because for the
life of me, I don't see it.

  Luis