linux-kernel - Re: [PATCH 1/4] asm-generic/page.h: apply page shift to PFN instead of VA in pfn_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZeEM5gBd/eigWreZ@yzhao56-desk.sh.intel.com>
Date: Fri, 1 Mar 2024 07:01:58 +0800
From: Yan Zhao <yan.y.zhao@...el.com>
To: Linus Walleij <linus.walleij@...aro.org>
CC: <arnd@...db.de>, <guoren@...nel.org>, <bcain@...cinc.com>,
	<jonas@...thpole.se>, <stefan.kristiansson@...nalahti.fi>,
	<shorne@...il.com>, <linux-arch@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-csky@...r.kernel.org>,
	<linux-hexagon@...r.kernel.org>, <linux-openrisc@...r.kernel.org>
Subject: Re: [PATCH 1/4] asm-generic/page.h: apply page shift to PFN instead
 of VA in pfn_to_virt

On Thu, Feb 29, 2024 at 02:34:35PM +0100, Linus Walleij wrote:
> On Wed, Jan 31, 2024 at 7:27 AM Yan Zhao <yan.y.zhao@...el.com> wrote:
> 
> > Apply the page shift to PFN to get physical address for final VA.
> > The macro __va should take physical address instead of PFN as input.
> >
> > Fixes: 2d78057f0dd4 ("asm-generic/page.h: Make pfn accessors static inlines")
> > Signed-off-by: Yan Zhao <yan.y.zhao@...el.com>
> 
> My bug, obviously. :(
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> I thought this was already applied with the other fixes, but maybe it
> was missed?
>
Hi Linus,
The other 3 in csky/hexagon/openrisc should have been applied in
https://lore.kernel.org/all/20240202140550.9886-1-yan.y.zhao@intel.com/.

This one in asm-generic is not, because Arnd said he is going to remove
the header as a whole soon. 

I explained it in the change log :)
"The pfn_to_virt() in asm-generic/page.h is not touched in this patch as
it's referenced by page_to_virt() in that header while the whole header is
going to be removed as a whole due to no one including it."

Thanks
Yan