linux-kernel - Re: [PATCH 1/4] asm-generic/page.h: apply page shift to PFN instead of VA in pfn_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ_XUmW__y=8R3aJkci+h-pHRh8-xH7ZmfRyQ=jjCbajw@mail.gmail.com>
Date: Thu, 29 Feb 2024 14:34:35 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Yan Zhao <yan.y.zhao@...el.com>
Cc: arnd@...db.de, guoren@...nel.org, bcain@...cinc.com, jonas@...thpole.se, 
	stefan.kristiansson@...nalahti.fi, shorne@...il.com, 
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-csky@...r.kernel.org, linux-hexagon@...r.kernel.org, 
	linux-openrisc@...r.kernel.org
Subject: Re: [PATCH 1/4] asm-generic/page.h: apply page shift to PFN instead
 of VA in pfn_to_virt

On Wed, Jan 31, 2024 at 7:27 AM Yan Zhao <yan.y.zhao@...el.com> wrote:

> Apply the page shift to PFN to get physical address for final VA.
> The macro __va should take physical address instead of PFN as input.
>
> Fixes: 2d78057f0dd4 ("asm-generic/page.h: Make pfn accessors static inlines")
> Signed-off-by: Yan Zhao <yan.y.zhao@...el.com>

My bug, obviously. :(
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

I thought this was already applied with the other fixes, but maybe it
was missed?

Yours,
Linus Walleij