[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <79D75E042AE5B03F+20240229100449.1001261-1-wangyuli@uniontech.com>
Date: Thu, 29 Feb 2024 18:04:49 +0800
From: WangYuli <wangyuli@...ontech.com>
To: herbert@...dor.apana.org.au,
davem@...emloft.net,
chenhuacai@...nel.org,
kernel@...0n.name
Cc: linux-crypto@...r.kernel.org,
loongarch@...ts.linux.dev,
linux-kernel@...r.kernel.org,
WangYuli <wangyuli@...ontech.com>,
Guan Wentao <guanwentao@...ontech.com>
Subject: [PATCH v2] LoongArch/crypto: Clean up useless assignment operations
The LoongArch CRC32 hw acceleration is based on
arch/mips/crypto/crc32-mips.c. While the MIPS code supports both
MIPS32 and MIPS64, LA32 lacks the CRC instruction. As a result,
"line len -= sizeof(u32)" is unnecessary.
Removing it can make context code style more unified and improve
code readability.
Suggested-by: Guan Wentao <guanwentao@...ontech.com>
Signed-off-by: WangYuli <wangyuli@...ontech.com>
---
arch/loongarch/crypto/crc32-loongarch.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/loongarch/crypto/crc32-loongarch.c b/arch/loongarch/crypto/crc32-loongarch.c
index a49e507af38c..3eebea3a7b47 100644
--- a/arch/loongarch/crypto/crc32-loongarch.c
+++ b/arch/loongarch/crypto/crc32-loongarch.c
@@ -44,7 +44,6 @@ static u32 crc32_loongarch_hw(u32 crc_, const u8 *p, unsigned int len)
CRC32(crc, value, w);
p += sizeof(u32);
- len -= sizeof(u32);
}
if (len & sizeof(u16)) {
@@ -80,7 +79,6 @@ static u32 crc32c_loongarch_hw(u32 crc_, const u8 *p, unsigned int len)
CRC32C(crc, value, w);
p += sizeof(u32);
- len -= sizeof(u32);
}
if (len & sizeof(u16)) {
--
2.43.0
Powered by blists - more mailing lists