linux-kernel - Re: [PATCH v2] LoongArch/crypto: Clean up useless assignment operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZermFgvsJymZkz4u@gondor.apana.org.au>
Date: Fri, 8 Mar 2024 18:19:02 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: WangYuli <wangyuli@...ontech.com>
Cc: davem@...emloft.net, chenhuacai@...nel.org, kernel@...0n.name,
	linux-crypto@...r.kernel.org, loongarch@...ts.linux.dev,
	linux-kernel@...r.kernel.org, wangyuli@...ontech.com,
	guanwentao@...ontech.com
Subject: Re: [PATCH v2] LoongArch/crypto: Clean up useless assignment
 operations

WangYuli <wangyuli@...ontech.com> wrote:
> The LoongArch CRC32 hw acceleration is based on
> arch/mips/crypto/crc32-mips.c. While the MIPS code supports both
> MIPS32 and MIPS64, LA32 lacks the CRC instruction. As a result,
> "line len -= sizeof(u32)" is unnecessary.
> 
> Removing it can make context code style more unified and improve
> code readability.
> 
> Suggested-by: Guan Wentao <guanwentao@...ontech.com>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> ---
> arch/loongarch/crypto/crc32-loongarch.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/arch/loongarch/crypto/crc32-loongarch.c b/arch/loongarch/crypto/crc32-loongarch.c
> index a49e507af38c..3eebea3a7b47 100644
> --- a/arch/loongarch/crypto/crc32-loongarch.c
> +++ b/arch/loongarch/crypto/crc32-loongarch.c
> @@ -44,7 +44,6 @@ static u32 crc32_loongarch_hw(u32 crc_, const u8 *p, unsigned int len)
> 
>                CRC32(crc, value, w);
>                p += sizeof(u32);
> -               len -= sizeof(u32);
>        }

This makes no sense whatsoever.  Please review this patch carefully
before you resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt