linux-kernel - Re: [PATCH v2] gpio: 74x164: Enable output pins after registers are reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15e6e45f-7398-4703-8154-35e769bac94a@gmail.com>
Date: Thu, 29 Feb 2024 14:23:47 +0200
From: Arturas Moskvinas <arturas.moskvinas@...il.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: linus.walleij@...aro.org, u.kleine-koenig@...gutronix.de,
 andriy.shevchenko@...ux.intel.com, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] gpio: 74x164: Enable output pins after registers are
 reset



On 2/29/24 10:54, Bartosz Golaszewski wrote:
> On Thu, Feb 29, 2024 at 9:47 AM Arturas Moskvinas
> <arturas.moskvinas@...il.com> wrote:
>> Chip outputs are enabled[1] before actual reset is performed[2] which might
>> cause pin output value to flip flop if previous pin value was set to 1 in chip.
>> Change fixes that behavior by making sure chip is fully reset before all outputs
>> are enabled.
>>
> Use imperative mood in commit messages - make it: "Fix that behavior
> by making sure ...".
Chip outputs are enabled[1] before actual reset is performed[2] which might
cause pin output value to flip flop if previous pin value was set to 1 
in chip.
Fix that behavior by making sure chip is fully reset before all outputs are
enabled.

Bartosz, does this look better?

Arturas Moskvinas