linux-kernel - Re: linux-next: build failure after merge of the kunit-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240302074643.6e1086ff@canb.auug.org.au>
Date: Sat, 2 Mar 2024 07:46:43 +1100
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: David Gow <davidgow@...gle.com>, Brendan Higgins
 <brendanhiggins@...gle.com>, Daniel Vetter <daniel.vetter@...ll.ch>, Intel
 Graphics <intel-gfx@...ts.freedesktop.org>, DRI
 <dri-devel@...ts.freedesktop.org>, Christian König
 <christian.koenig@....com>, Matthew Auld <matthew.auld@...el.com>, Linux
 Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>, Dave Airlie <airlied@...hat.com>
Subject: Re: linux-next: build failure after merge of the kunit-next tree

Hi Shuah,

On Fri, 1 Mar 2024 09:05:57 -0700 Shuah Khan <skhan@...uxfoundation.org> wrote:
>
> On 3/1/24 03:43, Stephen Rothwell wrote:
> > Hi all,
> > 
> > On Fri, 1 Mar 2024 15:15:02 +0800 David Gow <davidgow@...gle.com> wrote:  
> >>
> >> On Thu, 29 Feb 2024 at 23:07, Shuah Khan <skhan@...uxfoundation.org> wrote:  
> >>>
> >>> I can carry the fix through kselftest kunit if it works
> >>> for all.  
> >>
> >> I'm happy for this to go in with the KUnit changes if that's the best
> >> way to keep all of the printk formatting fixes together.

Unfortunately you can't fix this in the kunit-next tree without pulling
in Linus' tree (or the drm-fixes tree) - which seems excessive.
  
> > I am pretty sure that the proper fix has been applied to the
> > drm-fixes tree today (in the merge of the drm-misc-fixes tree).
> >   
> 
> What's the commit id for this fix? I Would like to include the details
> in my pull request to Linus.

My mistake, I misread the merge commit.  It has not been fixed in the
drm-misc-fixes tree or the drm-fixes tree (or Linus' tree since the
drm-fixes tree has been merged there) :-(

The problem in this case is not with the format string types, but with
a missing argument i.e. there is another argument required by the
format string.  It really should be fixed in the drm-misc-fixes tree
and sent to Linus post haste.

At least the change in the kunit-next tree will stop this happening in
the future.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped