linux-kernel - Re: [PATCH net-next] Simplify net_dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZeEj4TmNGuRhfAHf@chrisdown.name>
Date: Fri, 1 Mar 2024 00:40:01 +0000
From: Chris Down <chris@...isdown.name>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Petr Mladek <pmladek@...e.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Jessica Yu <jeyu@...nel.org>, Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Jason Baron <jbaron@...mai.com>, Jim Cromie <jim.cromie@...il.com>,
	Ilya Dryomov <idryomov@...il.com>, Xiubo Li <xiubli@...hat.com>,
	Jeff Layton <jlayton@...nel.org>, linux-kernel@...r.kernel.org,
	ceph-devel@...r.kernel.org
Subject: Re: [PATCH net-next] Simplify net_dbg_ratelimited() dummy

Geert Uytterhoeven writes:
>There is no need to wrap calls to the no_printk() helper inside an
>always-false check, as no_printk() already does that internally.
>
>Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

In the context of the larger printk index changes:

Acked-by: Chris Down <chris@...isdown.name>

>---
> include/linux/net.h | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/include/linux/net.h b/include/linux/net.h
>index c9b4a63791a45948..15df6d5f27a7badc 100644
>--- a/include/linux/net.h
>+++ b/include/linux/net.h
>@@ -299,10 +299,7 @@ do {									\
> 	net_ratelimited_function(pr_debug, fmt, ##__VA_ARGS__)
> #else
> #define net_dbg_ratelimited(fmt, ...)				\
>-	do {							\
>-		if (0)						\
>-			no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__); \
>-	} while (0)
>+	no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
> #endif
>
> #define net_get_random_once(buf, nbytes)			\
>-- 
>2.34.1
>