linux-kernel - Re: [PATCH v3] wifi: brcm80211: handle pmk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202402291640.9AAD719D3@keescook>
Date: Thu, 29 Feb 2024 16:40:36 -0800
From: Kees Cook <keescook@...omium.org>
To: Duoming Zhou <duoming@....edu.cn>
Cc: linux-kernel@...r.kernel.org, brcm80211-dev-list.pdl@...adcom.com,
	brcm80211@...ts.linux.dev, linux-wireless@...r.kernel.org,
	justinstitt@...gle.com, quic_alokad@...cinc.com,
	jisoo.jang@...sei.ac.kr, petr.tesarik.ext@...wei.com,
	hdegoede@...hat.com, johannes.berg@...el.com, kvalo@...nel.org,
	arend.vanspriel@...adcom.com
Subject: Re: [PATCH v3] wifi: brcm80211: handle pmk_op allocation failure

On Thu, Feb 29, 2024 at 06:31:53PM +0800, Duoming Zhou wrote:
> The kzalloc() in brcmf_pmksa_v3_op() will return null if the
> physical memory has run out. As a result, if we dereference
> the null value, the null pointer dereference bug will happen.
> 
> Return -ENOMEM from brcmf_pmksa_v3_op() if kzalloc() fails
> for pmk_op.
> 
> Fixes: a96202acaea4 ("wifi: brcmfmac: cfg80211: Add support for PMKID_V3 operations")
> Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Duoming Zhou <duoming@....edu.cn>

Thanks for the respin! :)

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook