linux-kernel - Re: [PATCH v2 0/9] drm: Switch from dev_err to dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 1 Mar 2024 09:47:04 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 owen <qwt9588@...il.com>, Jagan Teki <jagan@...rulasolutions.com>,
 Marek Vasut <marex@...x.de>, Adrien Grassein <adrien.grassein@...il.com>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Sam Ravnborg <sam@...nborg.org>, Bjorn Andersson <andersson@...nel.org>,
 Vinod Koul <vkoul@...nel.org>, Dmitry Baryshkov
 <dmitry.baryshkov@...aro.org>, Vinay Simha BN <simhavcs@...il.com>,
 Christopher Vollo <chris@...ewoutreach.org>,
 Jessica Zhang <quic_jesszhan@...cinc.com>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
Cc: kernel@...labora.com, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/9] drm: Switch from dev_err to dev_err_probe for
 missing DSI host error path

Il 01/03/24 01:12, Nícolas F. R. A. Prado ha scritto:
> This series changes every occurence of the following pattern:
> 
> 	dsi_host = of_find_mipi_dsi_host_by_node(dsi);
> 	if (!dsi_host) {
> 		dev_err(dev, "failed to find dsi host\n");
> 		return -EPROBE_DEFER;
> 	}
> 
> into
> 
> 	dsi_host = of_find_mipi_dsi_host_by_node(dsi);
> 	if (!dsi_host)
> 		return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n");
> 
> This registers the defer probe reason (so it can later be printed by the
> driver core or checked on demand through the devices_deferred file in
> debugfs) and prevents errors to be spammed in the kernel log every time
> the driver retries to probe, unnecessarily alerting userspace about
> something that is a normal part of the boot process.
> 
> I have omitted a Fixes: tag in the last patch, for the truly-nt35597
> panel, because it predates the dev_err_probe() helper.
> 
> Changes in v2:
> - Added patches 2 onwards to fix all occurences of this pattern instead
>    of just for the anx7625 driver
> - Link to v1: https://lore.kernel.org/r/20240226-anx7625-defer-log-no-dsi-host-v1-1-242b1af31884@collabora.com
> 

Apart from patch [8/9], where you're going over 100 cols, this series looks good.

After fixing that, on v3, please feel free to add my....

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

..to all of the patches in this series (and the one that you'll fix as well).

Cheers!
Angelo

> ---
> Nícolas F. R. A. Prado (9):
>        drm/bridge: anx7625: Don't log an error when DSI host can't be found
>        drm/bridge: icn6211: Don't log an error when DSI host can't be found
>        drm/bridge: lt8912b: Don't log an error when DSI host can't be found
>        drm/bridge: lt9611: Don't log an error when DSI host can't be found
>        drm/bridge: lt9611uxc: Don't log an error when DSI host can't be found
>        drm/bridge: tc358775: Don't log an error when DSI host can't be found
>        drm/bridge: dpc3433: Don't log an error when DSI host can't be found
>        drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found
>        drm/panel: truly-nt35597: Don't log an error when DSI host can't be found
> 
>   drivers/gpu/drm/bridge/analogix/anx7625.c     |  6 ++----
>   drivers/gpu/drm/bridge/chipone-icn6211.c      |  6 ++----
>   drivers/gpu/drm/bridge/lontium-lt8912b.c      |  6 ++----
>   drivers/gpu/drm/bridge/lontium-lt9611.c       |  6 ++----
>   drivers/gpu/drm/bridge/lontium-lt9611uxc.c    |  6 ++----
>   drivers/gpu/drm/bridge/tc358775.c             |  6 ++----
>   drivers/gpu/drm/bridge/ti-dlpc3433.c          | 17 +++++++++--------
>   drivers/gpu/drm/panel/panel-novatek-nt35950.c |  6 ++----
>   drivers/gpu/drm/panel/panel-truly-nt35597.c   |  6 ++----
>   9 files changed, 25 insertions(+), 40 deletions(-)
> ---
> base-commit: 2ae0a045e6814c8c1d676d6153c605a65746aa29
> change-id: 20240226-anx7625-defer-log-no-dsi-host-c3f9ccbcb287
> 
> Best regards,