linux-kernel - Re: [PATCH net-next 2/2] net: nlmon: Simplify nlmon_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b284da00-1eda-a352-8062-a2d81cdc24f2@iogearbox.net>
Date: Fri, 1 Mar 2024 15:09:53 +0100
From: Daniel Borkmann <daniel@...earbox.net>
To: Breno Leitao <leitao@...ian.org>, kuba@...nel.org, davem@...emloft.net,
 pabeni@...hat.com, edumazet@...gle.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, horms@...nel.org,
 dsahern@...nel.org
Subject: Re: [PATCH net-next 2/2] net: nlmon: Simplify nlmon_get_stats64

On 3/1/24 2:42 PM, Breno Leitao wrote:
> Do not set rtnl_link_stats64 fields to zero, since they are zeroed
> before ops->ndo_get_stats64 is called in core dev_get_stats() function.
> 
> Also, simplify the data collection by removing the temporary variable.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Acked-by: Daniel Borkmann <daniel@...earbox.net>