linux-kernel - Re: [PATCH v2] Staging: pi433: Updated bitrate range from datasheet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74ec69941cb67e3a351ebd23d5ad4a5b@iitb.ac.in>
Date: Mon, 04 Mar 2024 14:04:08 +0530
From: Aman Sharma <210100011@...b.ac.in>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Gregkh <gregkh@...uxfoundation.org>, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: pi433: Updated bitrate range from datasheet

Tbh this is my first patch and I don't have the hardware to test this. I 
thought updating the values from the datasheet directly might be a good 
idea as it would be the correct range. Please correct me if there is 
something that I missed / need to know.

On 2024-03-04 13:55, Dan Carpenter wrote:
> On Mon, Mar 04, 2024 at 11:23:40AM +0530, Aman Sharma wrote:
>> Updated bitrate range for FSK and OOK modulation from the RFM69 
>> Datasheet.
>> The values are mentioned in Section 2.3.2 of the datasheet.
> 
> Have you tested these as well?  Sending untested patches is not
> necessarily against the rules, but it seems like maybe you have this
> hardware and can test it.  Could you please talk about what testing you
> did?
> 
>> 
>> Signed-off-by: Aman Sharma<amansharma6122002@...il.com>
>                             ^
> Missing space.
> 

I'll fix this if I am allowed to submit a new patch.

> regards,
> dan carpenter