linux-kernel - Re: [PATCH v2] Staging: pi433: Updated bitrate range from datasheet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <835bba82-c144-4674-b8ec-a6bd6af89daa@moroto.mountain>
Date: Mon, 4 Mar 2024 13:18:53 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Aman Sharma <210100011@...b.ac.in>
Cc: Gregkh <gregkh@...uxfoundation.org>, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: pi433: Updated bitrate range from datasheet

On Mon, Mar 04, 2024 at 02:04:08PM +0530, Aman Sharma wrote:
> Tbh this is my first patch and I don't have the hardware to test this. I
> thought updating the values from the datasheet directly might be a good idea
> as it would be the correct range. Please correct me if there is something
> that I missed / need to know.
> 

No, patch is fine.  There is no downside to updating the .txt
documentation in this way.  I was just wondering.

> On 2024-03-04 13:55, Dan Carpenter wrote:
> > On Mon, Mar 04, 2024 at 11:23:40AM +0530, Aman Sharma wrote:
> > > Updated bitrate range for FSK and OOK modulation from the RFM69
> > > Datasheet.
> > > The values are mentioned in Section 2.3.2 of the datasheet.
> > 
> > Have you tested these as well?  Sending untested patches is not
> > necessarily against the rules, but it seems like maybe you have this
> > hardware and can test it.  Could you please talk about what testing you
> > did?
> > 
> > > 
> > > Signed-off-by: Aman Sharma<amansharma6122002@...il.com>
> >                             ^
> > Missing space.
> > 
> 
> I'll fix this if I am allowed to submit a new patch.

regards,
dan carpenter