[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9e4461ec-2207-42bb-a3a9-826eac1757da@linaro.org>
Date: Mon, 4 Mar 2024 09:11:02 +0000
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
Pratyush Yadav <pratyush@...nel.org>, Michael Walle <mwalle@...nel.org>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
Takahiro Kuwano <Takahiro.Kuwano@...ineon.com>
Cc: kernel@...labora.com, kernel-janitors@...r.kernel.org,
linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: core: correct type of i
Miquel,
Can you please queue this to mtd/next after you pull in the SPI NOR
changes? Thanks!
ta
On 3/4/24 09:01, Muhammad Usama Anjum wrote:
> The i should be signed to find out the end of the loop. Otherwise,
> i >= 0 is always true and loop becomes infinite. Make its type to be
> int.
>
> Fixes: 6a9eda34418f ("mtd: spi-nor: core: set mtd->eraseregions for non-uniform erase map")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org>
> ---
> Changes since v1:
> - Make i int instead of u8
> ---
> drivers/mtd/spi-nor/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 65b32ea59afc6..3e1f1913536bf 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -3373,7 +3373,7 @@ static u32
> spi_nor_get_region_erasesize(const struct spi_nor_erase_region *region,
> const struct spi_nor_erase_type *erase_type)
> {
> - u8 i;
> + int i;
>
> if (region->overlaid)
> return region->size;
Powered by blists - more mailing lists