linux-kernel - Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eed9bb0f-486f-47f3-b4b5-c07adda4a1c7@suse.de>
Date: Mon, 4 Mar 2024 11:32:42 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Jani Nikula <jani.nikula@...el.com>, Michael Ellerman
 <mpe@...erman.id.au>, linuxppc-dev@...ts.ozlabs.org
Cc: dri-devel@...ts.freedesktop.org, lkft-triage@...ts.linaro.org,
 linux-kernel@...r.kernel.org, Naresh Kamboju <naresh.kamboju@...aro.org>,
 Helge Deller <deller@....de>, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

Hi

Am 04.03.24 um 10:55 schrieb Jani Nikula:
> Removal of the backlight include from fb.h uncovered an implicit
> dependency in powerpc asm/backlight.h. Add the explicit include.
>
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Closes: https://lore.kernel.org/r/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com
> Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header")
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Helge Deller <deller@....de>
> Cc: linux-fbdev@...r.kernel.org
> Signed-off-by: Jani Nikula <jani.nikula@...el.com>
>
> ---
>
> Not even compile tested!

That's one of the cases that's hard to catch unless you get the config 
right.

> ---
>   arch/powerpc/include/asm/backlight.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/include/asm/backlight.h b/arch/powerpc/include/asm/backlight.h
> index 1b5eab62ed04..275d5bb9aa04 100644
> --- a/arch/powerpc/include/asm/backlight.h
> +++ b/arch/powerpc/include/asm/backlight.h
> @@ -10,6 +10,7 @@
>   #define __ASM_POWERPC_BACKLIGHT_H
>   #ifdef __KERNEL__
>   
> +#include <linux/backlight.h>

Thanks, but I think this should go directly into chipsfb.c. I would have 
provided a patch already, if our mail server didn't have issues this 
morning. Let me try again.

Best regards
Thomas

>   #include <linux/fb.h>
>   #include <linux/mutex.h>
>   

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)