[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <deae273c-7789-e8da-1256-777d01a4ab9f@huawei.com>
Date: Tue, 5 Mar 2024 21:47:56 +0800
From: Jason Yan <yanaijie@...wei.com>
To: John Garry <john.g.garry@...cle.com>, <jejb@...ux.ibm.com>,
<martin.petersen@...cle.com>, <chenxiang66@...ilicon.com>,
<jinpu.wang@...ud.ionos.com>, <artur.paszkiewicz@...el.com>,
<dlemoal@...nel.org>, <ipylypiv@...gle.com>
CC: <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/6] scsi: mvsas: Use LIBSAS_SHT_BASE
On 2024/3/5 21:28, John Garry wrote:
> On 05/03/2024 13:19, Jason Yan wrote:
>>> - .ioctl = sas_ioctl,
>>> -#ifdef CONFIG_COMPAT
>>> - .compat_ioctl = sas_ioctl,
>>> -#endif
>>> .shost_groups = mvst_host_groups,
>>> .sdev_groups = mvst_sdev_groups,
>>> .track_queue_depth = 1,
>>>
>>
>> Doesn't hvae ->eh_abort_handler too.
>
> Is setting eh_abort_handler actually really ever required for libsas
> drivers? We have sas_eh_abort_handler, so I assume so..
For now among libsas drivers only isci has eh_abort_handler. But
LIBSAS_SHT_BASE is setting it by default. I think it's better to keep
the same as before for other four drivers.
Thanks,
Jason
>
> Thanks,
> John
> .
Powered by blists - more mailing lists