linux-kernel - Re: [PATCH 5/6] scsi: mvsas: Use LIBSAS_SHT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afab3c4a-05b1-4da5-9646-34fbf988072c@oracle.com>
Date: Tue, 5 Mar 2024 15:26:57 +0000
From: John Garry <john.g.garry@...cle.com>
To: Jason Yan <yanaijie@...wei.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, chenxiang66@...ilicon.com,
        jinpu.wang@...ud.ionos.com, artur.paszkiewicz@...el.com,
        dlemoal@...nel.org, ipylypiv@...gle.com
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] scsi: mvsas: Use LIBSAS_SHT_BASE

On 05/03/2024 13:47, Jason Yan wrote:
>>>
>>> Doesn't hvae ->eh_abort_handler too.
>>
>> Is setting eh_abort_handler actually really ever required for libsas 
>> drivers? We have sas_eh_abort_handler, so I assume so..
> 
> For now among libsas drivers only isci has eh_abort_handler. But 
> LIBSAS_SHT_BASE is setting it by default. I think it's better to keep 
> the same as before for other four drivers.

Sure, but I do wonder why it is required for isci, if at all - I'll check.

The motivation to not require it is a smaller and consistent API used by 
all the libsas drivers.

Thanks,
John