linux-kernel - Re: [PATCH] Input: ili210x: Allow IRQ to share GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZedWNlNaJQEWdA9a@google.com>
Date: Tue, 5 Mar 2024 09:28:22 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Adam Ford <aford173@...il.com>
Cc: linux-input@...r.kernel.org, aford@...conembedded.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: ili210x:  Allow IRQ to share GPIO

Hi Adam,

On Wed, Feb 28, 2024 at 05:41:42AM -0600, Adam Ford wrote:
> The IRQ registration currently assumes that the GPIO is
> dedicated to it, but that may not necessarily be the case.
> If the board has another device sharing the IRQ, it won't be
> registered and the touch detect fails.

I do not believe the driver is prepared to handle shared interrupts.
First of all, it disables interrupts in the firmware update path, which
will interfere with operation of other device using the same line.

You also need to make sure the driver properly recognizes condition when
interrupt is raised by another device and Ilitek controller does not
have any data to transfer/return. In this case we need to make sure we
do not log any errors, not release any active contacts, etc.

Thanks.

-- 
Dmitry