linux-kernel - RE: Cover-cover letter for two resctrl patch sets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 5 Mar 2024 22:27:47 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: Konstantin Ryabitsev <konstantin@...uxfoundation.org>, "Chatre, Reinette"
	<reinette.chatre@...el.com>
CC: "Yu, Fenghua" <fenghua.yu@...el.com>, Peter Newman
	<peternewman@...gle.com>, Jonathan Corbet <corbet@....net>, Shuah Khan
	<skhan@...uxfoundation.org>, "x86@...nel.org" <x86@...nel.org>, Shaopeng Tan
	<tan.shaopeng@...itsu.com>, James Morse <james.morse@....com>, Jamie Iles
	<quic_jiles@...cinc.com>, Babu Moger <babu.moger@....com>, Randy Dunlap
	<rdunlap@...radead.org>, Drew Fustini <dfustini@...libre.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"patches@...ts.linux.dev" <patches@...ts.linux.dev>
Subject: RE: Cover-cover letter for two resctrl patch sets

>> Could you please instead send the two series separately
>> and note the dependency in the cover letter?
>
> FWIW, we're including ability to auto-retrieve and auto-apply dependencies
> with b4. It already works with preprequisite-patch-id trailers (as documented
> by git-format-patch), but we'll also add prerequisite-change-id in the near
> future as well.

Other interesting interactions with b4 in these patches:

1) Because of significant rebase changes, I dropped all the Reviewed/Tested tags
from v15. But b4 seems to have noticed that part 5/8 wasn't changed at all since
v14, and picked up some (but not all) of the tags for that patch:

  ✓ [PATCH v15 5/8] x86/resctrl: Add node-scope to the options for feature scope
    + Reviewed-by: Peter Newman <peternewman@...gle.com> (✗ DKIM/google.com)
    + Reviewed-by: Reinette Chatre <reinette.chatre@...el.com> (✓ DKIM/intel.com)
    + Reviewed-by: Babu Moger <babu.moger@....com> (✓ DKIM/amd.com)

2) My cover-cover letter created some linkage between the two patch series.
Trying to retrieve the 2-part v4 series with "git am" would pick up the 8-part
v15. Using an explicit "-v4" does work to pick up just the 2-part patch.
  $ b4 am -v4 20240228112952.8090-tony.luck@...el.com

3) That b4 am picks up Reinette's "if you make these changes" Reviewed by from:
  https://lore.kernel.org/all/12766261-26b2-4aa4-a735-c2380c4963fd@intel.com/
[though I can see why it did and realize that we'll need "b4GPT" to parse
surrounding text to figure out that it should skip that].

Should folks that offer a conditional tag mark that in the text somewhere to
let b4 know not to auto-pick?

-Tony