linux-kernel - Re: [PATCH] Skyhighmemory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 5 Mar 2024 08:39:57 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: "Kyeongrho.Kim" <kr.kim@...highmemory.com>
Cc: "richard@....at" <richard@....at>, "vigneshr@...com" <vigneshr@...com>,
 "mmkurbanov@...utedevices.com" <mmkurbanov@...utedevices.com>,
 "ddrokosov@...rdevices.ru" <ddrokosov@...rdevices.ru>,
 "gch981213@...il.com" <gch981213@...il.com>,
 "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Mohamed
 Sardi <moh.sardi@...highmemory.com>, "Changsub.Shim"
 <changsub.shim@...highmemory.com>
Subject: Re: [PATCH] Skyhighmemory

Hello,

kr.kim@...highmemory.com wrote on Tue, 5 Mar 2024 02:28:31 +0000:

> Hello Miquel,
> 
> Please find the reply in below.
> 
> I tried to send an email using 'git send-email', but '5.1.3 Invalid address' error is occurring, so I send it to Outlook first.

I'm sorry but I will now wait for your setup to be fixed.

> > spinand_device *spinand)  static int spinand_ecc_enable(struct spinand_device *spinand,  
> 
> >                       bool enable)  
> 
> >  {  
> 
> > +   /* SHM : always ECC enable */  
> 
> > +   if (spinand->flags & SPINAND_ON_DIE_ECC_MANDATORY)  
> 
> > +         return 0;  
> 
> > +  
> 
> 
> 
> Can you please move this logic to your vendor driver?
> 
> SHM's SPI Nand must have “ECC Always on” applied.

Why? Disabling the ECC is not possible? In this case extra care must be
taken in the driver.

> 
> However, I think there is no way to be moved to the vendor driver.
> 

..

> > +static int skyhigh_spinand_ooblayout_ecc(struct mtd_info *mtd, int section,  
> 
> > +                           struct mtd_oob_region *region)  
> 
> > +{  
> 
> > +   if (section)  
> 
> > +         return -ERANGE;  
> 
> > +  
> 
> > +   region->length = 0;  
> 
> > +   region->offset = mtd->oobsize;  
> 
> 
> 
> The ECC bytes are not stored anywhere?
> 
> There is no problem because skyhigh's ecc parity is stored in the internal hidden area and is not needed for them.

Please add a comment.

Thanks,
Miquèl