linux-kernel - Re: [PATCH] loongarch: rust: Switch to use built-in rustc target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H666zsMadZuzvcRxxkUxSpkka1tt9AJO_WctHDL8j_HNg@mail.gmail.com>
Date: Tue, 5 Mar 2024 17:58:42 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: WANG Rui <wangrui@...ngson.cn>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Wedson Almeida Filho <wedsonaf@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, Jamie Cunliffe <Jamie.Cunliffe@....com>, 
	Catalin Marinas <catalin.marinas@....com>, WANG Xuerui <kernel@...0n.name>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	loongarch@...ts.linux.dev, loongson-kernel@...ts.loongnix.cn
Subject: Re: [PATCH] loongarch: rust: Switch to use built-in rustc target

Hi, Miguel,

On Tue, Mar 5, 2024 at 12:07 AM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Mon, Mar 4, 2024 at 3:14 PM WANG Rui <wangrui@...ngson.cn> wrote:
> >
> > This commit switches to using the built-in rustc
> > loongarch64-unknown-none-softfloat target for LoongArch.
> >
> > The Rust samples have been tested with this commit.
> >
> > Signed-off-by: WANG Rui <wangrui@...ngson.cn>
> > ---
> > base-commit: ("rust: Refactor the build target to allow the use of builtin targets")
>
> I couldn't apply it on top of commit f82811e22b48 in arm64's tree
> (which is the base? -- the offset differs significantly in the arch
> Makefile), but I nevertheless applied it manually on top of that one,
> build-tested it for loongarch64 and boot-tested it for x86_64:
>
> Acked-by: Miguel Ojeda <ojeda@...nel.org>
> Tested-by: Miguel Ojeda <ojeda@...nel.org>
The base of the loongarch tree doesn't contain the arm64 modifications
now, so this patch is better to be applied on the rust tree with my
Acked-by. But if you have some trouble doing that, I can also manually
merge the arm64 parts to the loongarch tree, and then apply this
patch. Thanks.

Huacai

>
> Thanks!
>
> Cheers,
> Miguel