linux-kernel - Re: [PATCH v4 2/2] sched/fair: Use helper function to access rd->overutilized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240305101941.c5foq7v43xwohrzp@airbuntu>
Date: Tue, 5 Mar 2024 10:19:41 +0000
From: Qais Yousef <qyousef@...alina.io>
To: Shrikanth Hegde <sshegde@...ux.ibm.com>
Cc: mingo@...nel.org, peterz@...radead.org, vincent.guittot@...aro.org,
	yu.c.chen@...el.com, dietmar.eggemann@....com,
	linux-kernel@...r.kernel.org, nysal@...ux.ibm.com,
	aboorvad@...ux.ibm.com, srikar@...ux.ibm.com, vschneid@...hat.com,
	pierre.gondois@....com, morten.rasmussen@....com
Subject: Re: [PATCH v4 2/2] sched/fair: Use helper function to access
 rd->overutilized

On 03/04/24 13:58, Shrikanth Hegde wrote:
> 
> 
> On 3/4/24 12:24 AM, Qais Yousef wrote:
> > On 03/01/24 20:47, Shrikanth Hegde wrote:
> >> Overutilized field is accessed directly in multiple places.
> >> So it could use a helper function. That way one might be more
> >> informed that it needs to be used only in case of EAS.
> >>
> >> No change in functionality intended.
> >>
> >> Signed-off-by: Shrikanth Hegde <sshegde@...ux.ibm.com>
> > 
> > Can we do the same for rd->overload too? A set_rd_overload_status() would be
> > a nice addition too. Anyway.
> 
> 
> We have some more experiments going around overload. 
> For example, currently it is writing sg_status & SG_OVERLOAD without checking if it has 
> changed first. On large systems that are not overloaded, that may help by reducing the 
> bus traffic. 
> 
> I will pick up this after we have some more data on the above. 

*thumps up*

> 
> > 
> > Reviewed-by: Qais Yousef <qyousef@...alina.io>
> > 
> 
> Thank you.
> 
> > 
> > Thanks!