linux-kernel - Re: [EXTERNAL] Re: [PATCH v6 1/5] net: wan: Add support for QMC HDLC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240306082230.7ecf207b@kernel.org>
Date: Wed, 6 Mar 2024 08:22:30 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Ratheesh Kannoth <rkannoth@...vell.com>, Herve Codina
 <herve.codina@...tlin.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v6 1/5] net: wan: Add support for QMC
 HDLC

On Wed, 6 Mar 2024 16:01:48 +0000 Ratheesh Kannoth wrote:
> > > > +	struct qmc_hdlc_desc *desc = context;
> > > > +	struct net_device *netdev = desc->netdev;
> > > > +	struct qmc_hdlc *qmc_hdlc = netdev_to_qmc_hdlc(netdev);  
> > > Reverse xmas tree  
> > 
> > The reverse xmas tree order cannot be used here.
> > qmc_hdlc depends on netdev, netdev depends on desc.
> >   
> ACK. Usually I get comments to split declaration and assignment for
> my patches in upstream. 

Yup, that's our general preference, to split the init out of 
the definition.