linux-kernel - Re: [PATCH v6 1/5] net: wan: Add support for QMC HDLC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240306082259.5a29a5aa@kernel.org>
Date: Wed, 6 Mar 2024 08:22:59 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Yury Norov <yury.norov@...il.com>, Herve Codina
 <herve.codina@...tlin.com>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Rasmus Villemoes
 <linux@...musvillemoes.dk>, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, Andrew Lunn
 <andrew@...n.ch>, Mark Brown <broonie@...nel.org>, Christophe Leroy
 <christophe.leroy@...roup.eu>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v6 1/5] net: wan: Add support for QMC HDLC

On Wed, 6 Mar 2024 15:38:10 +0200 Andy Shevchenko wrote:
> > It's minor, but you can avoid conditionals doing something like:
> > 
> > 		netdev->stats.rx_over_errors += !!(flags & QMC_RX_FLAG_HDLC_OVF);  
> 
> This is harder to read. 

+1