linux-kernel - Re: [EXTERNAL] Re: [PATCH v6 1/5] net: wan: Add support for QMC HDLC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 6 Mar 2024 18:46:11 +0100
From: Herve Codina <herve.codina@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Ratheesh Kannoth <rkannoth@...vell.com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v6 1/5] net: wan: Add support for QMC
 HDLC

Hi Jakub,

On Wed, 6 Mar 2024 08:22:30 -0800
Jakub Kicinski <kuba@...nel.org> wrote:

> On Wed, 6 Mar 2024 16:01:48 +0000 Ratheesh Kannoth wrote:
> > > > > +	struct qmc_hdlc_desc *desc = context;
> > > > > +	struct net_device *netdev = desc->netdev;
> > > > > +	struct qmc_hdlc *qmc_hdlc = netdev_to_qmc_hdlc(netdev);    
> > > > Reverse xmas tree    
> > > 
> > > The reverse xmas tree order cannot be used here.
> > > qmc_hdlc depends on netdev, netdev depends on desc.
> > >     
> > ACK. Usually I get comments to split declaration and assignment for
> > my patches in upstream.   
> 
> Yup, that's our general preference, to split the init out of 
> the definition.

Does it mean that I need to update in a next iteration ?

Best regards,
Hervé