linux-kernel - Re: [PATCH v3] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240306-decay-overbid-9c8ea43a511f@spud>
Date: Wed, 6 Mar 2024 18:38:49 +0000
From: Conor Dooley <conor@...nel.org>
To: Naresh Solanki <naresh.solanki@...ements.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, mazziesaccount@...il.com,
	linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] dt-bindings: hwmon: tda38640: Add interrupt &
 regulator properties

On Wed, Mar 06, 2024 at 03:20:02PM +0530, Naresh Solanki wrote:
> Hi Krzysztof,
> 
> 
> On Wed, 6 Mar 2024 at 12:44, Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
> >
> > On 05/03/2024 22:07, Naresh Solanki wrote:
> > > Add properties for interrupt & regulator.
> > > Also update example.
> >
> > Nothing improved.
> Yes, Just aligned the regulator node name in this revision.
> I missed aligning the commit message.
> 
> I'll fix in next revision & update commit message as:
> 
> tda38640 has a single regulator output along with
> CAT_FAULT# pin to report internal events.
> Hence add properties for regulator & interrupt.
> 
> Let me know if any others changes needed.

That should be fine - but your line wrapping is really odd, you can make
use of 72 characters but you are wrapping at ~50.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)